Declarative Config Spec Docs - Schema transform#9654
Merged
chalin merged 14 commits intoopen-telemetry:mainfrom Apr 23, 2026
Merged
Declarative Config Spec Docs - Schema transform#9654chalin merged 14 commits intoopen-telemetry:mainfrom
chalin merged 14 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
dependencies
otelbot-docs
Bot
added
the
missing:docs-approval
theletterf
approved these changes
Apr 15, 2026
otelbot-docs
Bot
added
ready-to-be-merged
jack-berg
approved these changes
Apr 15, 2026
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Looks good. Verified by running against my local copy of opentelemetry-configuration/opentelemetry_configuration.json.
When is opentelemetry-configuration going to be added to .gitmodules?
Member
Author
I had assumed #9448 would land before this so I didn't include it in this one |
chalin
approved these changes
Apr 23, 2026
Contributor
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
RSLGTM. See below for one non-blocking suggestion.
| "test:compound-tests": "npm run seq -- check:code-excerpts $(CMD_SKIP=collector-sync npm -s run _list:test:compound-tests)", | ||
| "test:edge-functions:live": "npm run _test:ef:live --", | ||
| "test:edge-functions": "node --test \"netlify/edge-functions/**/*.test.ts\"", | ||
| "test:js-unit": "node --test \"assets/js/**/*.test.mjs\"", |
Contributor
There was a problem hiding this comment.
Maybe this should be named test:config-schema?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #9521
The completed implementation we are working towards is in #9383 - here is the final page this code will be a part of. I am breaking things up to hopefully make reviewing this easier
Context for this change:
We are going to have the
opentelemetry-configurationrepo as a git submodule, and then mount the schema json file as a static asset for the site. We will then use theassets/js/configSchemaTransform.mjsscript in this PR in order to convert the raw schema data into a format that is easier to use with the page we are building.cc @jack-berg
Footnotes
Yes, I can answer maintainer questions about the content of this PR, without using AI. ↩